Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the {fixed,standard,zip317}::SingleOutputChangeStrategy doc comments more accurate concerning the choice of output pool #1509

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

daira
Copy link
Contributor

@daira daira commented Aug 22, 2024

Thanks to @AArnott for pointing out the inaccuracy.

…utChangeStrategy`

doc comments more accurate concerning the choice of output pool.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.16%. Comparing base (4b70940) to head (0348af6).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   61.16%   61.16%   -0.01%     
==========================================
  Files         141      141              
  Lines       16649    16649              
==========================================
- Hits        10184    10183       -1     
- Misses       6465     6466       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, doc-only.

@nuttycom nuttycom merged commit cdf993d into zcash:main Sep 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants