zcash_keys: Add decode_extfvk_with_network
#1523
Conversation
nuttycom
force-pushed
the
keys/decode_extfvk_with_network
branch
from
9adc4ea
to
101e0b2
Compare
nuttycom
force-pushed
the
keys/decode_extfvk_with_network
branch
from
101e0b2
to
897018a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
- Coverage 61.16% 61.06% -0.10%
==========================================
Files 141 141
Lines 16649 16675 +26
==========================================
Hits 10183 10183
- Misses 6466 6492 +26 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
keys/decode_extfvk_with_network
branch
2 times, most recently
from
e4dbf11
to
7c05fcb
Compare
nuttycom
force-pushed
the
keys/decode_extfvk_with_network
branch
from
7c05fcb
to
a732932
Compare
| /// Decodes an [`ExtendedFullViewingKey`] and the [`NetworkType`] that it is intended for use with | ||
| /// from a Bech32-encoded string. | ||
| #[cfg(feature = "sapling")] | ||
| pub fn decode_extfvk_with_network( |
There was a problem hiding this comment.
I know the other functions in this file don't explicitly say in their names that they're for Sapling, but that still seems odd. Non-blocking; I don't think we can do anything about it right now, but we should consider moving them to a zcash_keys::sapling::encoding module if they are never going to be more general.
| let (decoded_hrp, data, variant) = bech32::decode(s)?; | ||
| if variant != Variant::Bech32 { | ||
| Err(Bech32DecodeError::IncorrectVariant(variant)) | ||
| } else { |
There was a problem hiding this comment.
Consider using CheckedHrpstring::new::<Bech32> (although I'm not sure it really comes out any cleaner once error handling has been taken into account).
No description provided.