Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip321: Add missing test-dependencies feature configuration. #1528

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Sep 4, 2024

No description provided.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.45%. Comparing base (db06580) to head (2ce78be).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
- Coverage   61.07%   60.45%   -0.62%     
==========================================
  Files         142      147       +5     
  Lines       16710    17115     +405     
==========================================
+ Hits        10205    10347     +142     
- Misses       6505     6768     +263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 155c56e.

Cargo.toml Outdated Show resolved Hide resolved
components/zcash_protocol/Cargo.toml Outdated Show resolved Hide resolved
zcash_primitives/Cargo.toml Outdated Show resolved Hide resolved
@str4d str4d force-pushed the fix/zip321-test-dependencies branch from e486a24 to 2ce78be Compare September 16, 2024 19:16
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2ce78be

@str4d str4d merged commit f7228a5 into zcash:main Sep 16, 2024
26 of 27 checks passed
@nuttycom nuttycom deleted the fix/zip321-test-dependencies branch September 20, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants