-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BlockCache trait for FsBlockDb #1535
base: main
Are you sure you want to change the base?
Implement BlockCache trait for FsBlockDb #1535
Conversation
e0d5339
to
4995d68
Compare
async fn read<WalletErrT>( | ||
&self, | ||
range: &ScanRange, | ||
) -> Result<Vec<CompactBlock>, error::Error<WalletErrT, Self::Error>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something that is happening on the BlockSource
trait as well, but both BlockSource
and BlockCache
traits have nothing to do with the Wallet, so it's leaky and weird to have to parameterize methods on these traits based on the Wallet (more specifically what errors the Wallet throws).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, my original PR for this work actually removed the wallet errors from BlockSource instead of adding them to BlockCache. However, I am not sure of the intention behind WalletErrT so I wanted to leave this undisrupted.
BlockCache::read
for BlockDb, neccessary for callingscan_cached_blocks