zcash_client_backend: Fix tor::Client::create argument
#1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional closure was requiring a type annotation when using `None`, which would create a more complex API than just passing an empty closure.
nuttycom
previously approved these changes
Feb 11, 2025
daira
reviewed
Feb 11, 2025
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
nuttycom
approved these changes
Feb 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 54.39% 54.36% -0.04%
==========================================
Files 174 175 +1
Lines 20313 20325 +12
==========================================
Hits 11050 11050
- Misses 9263 9275 +12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional closure was requiring a type annotation when using
None, which would create a more complex API than just passing an empty closure.