Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call init_wallet_db in Wallet::open #19

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Call init_wallet_db in Wallet::open #19

merged 1 commit into from
Feb 7, 2025

Conversation

str4d
Copy link
Collaborator

@str4d str4d commented Jan 31, 2025

This ensures that the database file exists and has the latest migrations applied.

Limitation: it does not yet handle migrations that require access to a seed, which means it won't work with existing old zcash_client_sqlite databases (migrate these with zcash-devtool wallet upgrade first).

This ensures that the database file exists and has the latest migrations
applied.

Limitation: it does not yet handle migrations that require access to a
seed, which means it won't work with existing old `zcash_client_sqlite`
databases (migrate these with `zcash-devtool wallet upgrade` first).
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 0ce2a79 into main Feb 7, 2025
@str4d str4d deleted the init-wallet-db branch February 7, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants