Support tagged ZIP 32 child derivation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
commented
Feb 12, 2025
daira
force-pushed
the
add-prfexpand-with-tag
branch
from
0f687c5 to
ae219c7
Compare
(for tagged ZIP 32 child derivation). Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
add-prfexpand-with-tag
branch
from
ae219c7 to
0d3f591
Compare
nuttycom
reviewed
Feb 14, 2025
nuttycom
previously approved these changes
Feb 17, 2025
str4d
reviewed
Feb 17, 2025
src/prf_expand.rs
Outdated
Comment on lines
125
to
121
| match lead { | ||
| None => self.apply(c_par, &[sk_par, i, tag]), | ||
| Some(b) => self.apply(c_par, &[sk_par, i, &[b], tag]), | ||
| } |
There was a problem hiding this comment.
zcash/zips#978 says that the input to PRF^Expand is sk_par || i if lead == 0 && tag.is_empty(). Here if lead = None then the tag still gets appended. We should instead do something like lead.unwrap_or(0) and then the full check.
Co-authored-by: Jack Grigg <jack@electriccoin.co> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
add-prfexpand-with-tag
branch
from
a07c889 to
a0d5af6
Compare
of `PrfExpand` (e.g. the `zip32` crate). Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
add-prfexpand-with-tag
branch
from
5987f26 to
295ed47
Compare
This was referenced Feb 18, 2025
nuttycom
reviewed
Feb 19, 2025
src/prf_expand.rs
Outdated
| pub const REGISTERED_ZIP32_CHILD: Self = Self::new(0xAC); | ||
|
|
||
| /// Expands the given secret key in this domain. | ||
| pub fn with(self, sk: &[u8], a: &[u8; 32], b: &[u8; 4], c: Option<(u8, &[u8])>) -> [u8; 64] { |
There was a problem hiding this comment.
Is it intended that Some((0, &[])) be a valid input to this function?
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
add-prfexpand-with-tag
branch
from
201d5e6 to
997bf72
Compare
nuttycom
approved these changes
Feb 19, 2025
str4d
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.