Use user_id as token set indicator for settings (All-Hands-AI#6595)

Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>

openhands/server/routes/settings.py

@@ -13,20 +13,19 @@
 @app.get('/settings')
 async def load_settings(request: Request) -> GETSettingsModel | None:
     try:
-        settings_store = await SettingsStoreImpl.get_instance(
-            config, get_user_id(request)
-        )
+        user_id = get_user_id(request)
+        settings_store = await SettingsStoreImpl.get_instance(config, user_id)
         settings = await settings_store.load()
         if not settings:
             return JSONResponse(
                 status_code=status.HTTP_404_NOT_FOUND,
                 content={'error': 'Settings not found'},
             )
 
-        github_token = request.state.github_token
+        token_is_set = bool(user_id) or bool(request.state.github_token)
         settings_with_token_data = GETSettingsModel(
             **settings.model_dump(),
-            github_token_is_set=bool(github_token),
+            github_token_is_set=token_is_set,
         )
         settings_with_token_data.llm_api_key = settings.llm_api_key
 

openhands/server/services/github_service.py

@@ -9,10 +9,10 @@
 
 class GitHubService:
     BASE_URL = 'https://api.github.com'
+    token: str = ''
 
     def __init__(self, user_id: str | None):
         self.user_id = user_id
-        self.token = ''
 
     async def _get_github_headers(self):
         """