Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete TODO: Add descriptive error messages to docset initialization failure #1661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amini-allight
Copy link

While authoring a new Zeal docset recently I configured the docset wrong and had to debug the issue, but the only error message Zeal would give me was:

Could not load docset from 'PATH'. Reinstall the docset.

I went through the code trying to find the root cause of this error and discovered a TODO in src/libs/registry/docset.cpp suggesting that the errors leading to that message should be reported in more detail. I decided to try fix this myself, which is what this pull request does, adding new error messages for missing directories or files and for a malformed Info.plist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant