component: Add component and component_preview crates to power UI components
#24456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
iamnbutler
changed the title
component and component_preview crates to power ui components
maxdeviant
changed the title
component and component_preview crates to power ui componentscomponent and component_preview crates to power UI components
|
We should consider using |
maxdeviant
added a commit
that referenced
this pull request
Feb 9, 2025
This PR removes the `ToolStrip` component. Pulling this change out of #24456. Release Notes: - N/A
osiewicz
pushed a commit
that referenced
this pull request
Feb 10, 2025
This PR removes the `ToolStrip` component. Pulling this change out of #24456. Release Notes: - N/A
osiewicz
pushed a commit
that referenced
this pull request
Feb 10, 2025
… components (#24456) This PR formalizes design components with the Component and ComponentPreview traits. You can open the preview UI with `workspace: open component preview`. Component previews no longer need to return `Self` allowing for more complex previews, and previews of components like `ui::Tooltip` that supplement other components rather than are rendered by default. `cargo-machete` incorrectly identifies `linkme` as an unused dep on crates that have components deriving `IntoComponent`, so you may need to add this to that crate's `Cargo.toml`: ```toml # cargo-machete doesn't understand that linkme is used in the component macro [package.metadata.cargo-machete] ignored = ["linkme"] ``` Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formalizes design components with the Component and ComponentPreview traits.
You can open the preview UI with
workspace: open component preview.Component previews no longer need to return
Selfallowing for more complex previews, and previews of components likeui::Tooltipthat supplement other components rather than are rendered by default.cargo-macheteincorrectly identifieslinkmeas an unused dep on crates that have components derivingIntoComponent, so you may need to add this to that crate'sCargo.toml:Release Notes: