gpui: Fix scroll_to_reveal_item scrolling for visible items#52565
Open
Skxxtz wants to merge 1 commit intozed-industries:mainfrom
Open
gpui: Fix scroll_to_reveal_item scrolling for visible items#52565Skxxtz wants to merge 1 commit intozed-industries:mainfrom
scroll_to_reveal_item scrolling for visible items#52565Skxxtz wants to merge 1 commit intozed-industries:mainfrom
Conversation
…s already in view
scroll_to_reveal_item scrolling even though item i…scroll_to_reveal_item scrolling even though item list
scroll_to_reveal_item scrolling even though item listscroll_to_reveal_item scrolling for visible items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved List Navigation: Nearest Scroll Strategy
Description
This PR refactors
scroll_to_reveal_itemingpuito prevent unnecessary "jumping" when navigating through a list.Previously, moving "Up" would aggressively snap the selected item to the top of the viewport even if it was already fully visible.
Previous behavior:
2026-03-27.11-43-34.mp4
New behavior:
2026-03-27.11-45-25.mp4
How:
The new implementation uses pixel-coordinate math (via
SumTreecursors) to implement a Nearest scroll strategy:This creates a much smoother experience in the Launcher and other list-heavy interfaces where users frequently toggle between adjacent items.
Self-Review Checklist:
Release Notes: