Skip to content

cli: Null stdio handles when spawning Zed on Windows#52583

Open
Dnreikronos wants to merge 1 commit intozed-industries:mainfrom
Dnreikronos:fix/cli-mintty-ctrl-key-buffer
Open

cli: Null stdio handles when spawning Zed on Windows#52583
Dnreikronos wants to merge 1 commit intozed-industries:mainfrom
Dnreikronos:fix/cli-mintty-ctrl-key-buffer

Conversation

@Dnreikronos
Copy link
Copy Markdown
Contributor

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #51101

Release Notes:

  • Fixed launching Zed from Git Bash (MinTTY) on Windows leaving a ctrl modifier stuck in the terminal buffer, so the next keystroke after zed was read as Ctrl+key. The CLI now nulls stdio handles when spawning Zed in the background.

Demo

Before:

before.mp4

After:

after.mp4

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 27, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, MrSubidubi and SomeoneToIgnore and removed request for a team March 27, 2026 16:14
@maxdeviant maxdeviant changed the title cli: Null stdio handles when spawning Zed on Windows (fixes #51101) cli: Null stdio handles when spawning Zed on Windows Mar 27, 2026
@MrSubidubi MrSubidubi removed their assignment Mar 28, 2026
@MrSubidubi MrSubidubi requested review from reflectronic and removed request for MrSubidubi and SomeoneToIgnore March 28, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starting Zed from bash console leaves a ctrl character in the buffer

3 participants