collab_panel: Persist favorited channels in the global KV store#52600
Open
danilo-leal wants to merge 3 commits intomainfrom
Open
collab_panel: Persist favorited channels in the global KV store#52600danilo-leal wants to merge 3 commits intomainfrom
danilo-leal wants to merge 3 commits intomainfrom
Conversation
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
staff
zed-codeowner-coordinator
bot
requested review from
a team,
kubkon and
reflectronic
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #52541
Favorite channels weren't appearing on multiple windows because they were serialized in a given window's collab panel state. This PR moves them to the global key value store. Also, solved a little issue with non-unique ids which was making clicking on the original instance of a favorite channel do nothing.
Release Notes: