Reduce header interdependency #2281
Open
+295
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadmic
reviewed
Oct 27, 2024
Comment on lines
+48
to
+51
| s32 (*unk_2C)(struct MapMarkIconData***[3]); | ||
| s32 (*unk_30)(struct MapMarkIconData***[3]); | ||
| void (*unk_34)(struct PauseMapMarkData**[3]); | ||
| void (*unk_38)(struct PauseMapMarkData**[3]); |
There was a problem hiding this comment.
I find these and the void(**)(struct PlayState*) below much less readable than with the typedef. Is it really worth it?
|
ultra64.h should not be split like this, it is a common n64 header file. |
|
I also am not sure about the specific libultra includes that are occurring in these changes. Pretty sure the intent is that libultra provides a public interface and the game isnt supposed to be able to include specific stuff directly like this, but people more familiar with libultra would have to weigh in |
|
I just feel that including the entirety of libultra when a file only needs the ultratypes is overkill and some files already did it this way so I thought it'd be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces some instances of headers needlessly depending on other headers, should help with BSS stability.