-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document a bunch of info tables (based on comments mainly) #2290
Open
Feacur
wants to merge
13
commits into
zeldaret:main
Choose a base branch
from
Feacur:doc/info_tables_based_on_comments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+300
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was already documented as comments along matching by - @EllipticEllipsis - @Roman971 ed4021a
was already documented as comments along EVENTCHKINF creation by - @Dragorn421 6336df5
was already documented by - fig02 7927e7b
was already documented by - mzxrules - fig02 3fd05c9
was already documented as comments along matching by - @EllipticEllipsis - @fig02 9d63626
was already documented during matching by - @shawlucas - @fig02 7097876
because ae4a9dc constants got renamed
original commit: 6336df5
cadmic
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general reasoning:
concerning the dialogues with Gorons @
z_en_go.c
:one way or another will conflict a bit with #2299 at some info tables. negligible, just for me to keep in mind