fix: make 'Always floating' setting work on new tabs #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i hope this get merged :) |
|
There's also some bugs in general regarding floating tabs -- notably you have to double click outside of the bounds or press ESC twice to clear it, where the regular URL bar only requires one click or one ESC. Maybe this can be another PR or you want to look into it? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Always floating" setting wasn't being applied when opening new tabs.
Fixed by making the setting properly apply to newly opened tabs.
Note: This is my first PR as I'm discovering the codebase - any feedback is welcome if something needs to be improved!
Demo
Before
Screencast_20250128_123612.webm
After
Screencast_20250128_123954.webm