Skip to content

Added a preference to toggle the sidebar opening on hover in compact mode #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 19, 2025
Merged

Added a preference to toggle the sidebar opening on hover in compact mode #4792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4cbf574
Added a preference to toggle the sidebar opening on hover in compact …
afonsofrancof Jan 31, 2025
908c811
refactor: the hoverableElements function to be more readable
joshdonnell Feb 11, 2025
17b72bc
fix: hoverableElements function to include the container by default
joshdonnell Feb 11, 2025
ee0bcfc
Merge pull request #1 from joshdonnell/dev
afonsofrancof Feb 11, 2025
4ce9385
Fix formatting
afonsofrancof Feb 11, 2025
1b8891a
Made the loading of the sidebar hover preference lazy
afonsofrancof Feb 18, 2025
2345e14
Applied the show-on-hover preference to the topbar aswell.
afonsofrancof Feb 18, 2025
a3af69c
Changed the preference name to include toolbar
afonsofrancof Feb 18, 2025
dccee58
Added the window buttons
afonsofrancof Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/browser/app/profile/zen-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ pref('zen.view.compact.toolbar-hide-after-hover.duration', 1000);
pref('zen.view.compact.color-toolbar', true);
pref('zen.view.compact.color-sidebar', true);
pref('zen.view.compact.animate-sidebar', true);
pref('zen.view.compact.show-sidebar-and-toolbar-on-hover', true);

pref('zen.urlbar.behavior', 'floating-on-type'); // default, floating-on-type, float

Expand Down
27 changes: 20 additions & 7 deletions src/browser/base/zen-components/ZenCompactMode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,15 +276,28 @@ var gZenCompactModeManager = {
},

get hoverableElements() {
if (typeof this._showSidebarAndToolbarOnHover === 'undefined') {
this._showSidebarAndToolbarOnHover = Services.prefs.getBoolPref(
'zen.view.compact.show-sidebar-and-toolbar-on-hover',
true
);
}
return [
...(!this._showSidebarAndToolbarOnHover
? []
: [
{
element: this.sidebar,
screenEdge: this.sidebarIsOnRight ? 'right' : 'left',
keepHoverDuration: 100,
},
{
element: document.getElementById('zen-appcontent-navbar-container'),
screenEdge: 'top',
},
]),
{
element: this.sidebar,
screenEdge: this.sidebarIsOnRight ? 'right' : 'left',
keepHoverDuration: 100,
},
{
element: document.getElementById('zen-appcontent-navbar-container'),
screenEdge: 'top',
element: gZenVerticalTabsManager.actualWindowButtons,
},
];
},
Expand Down