Skip to content

Commit

Permalink
bump version to 1.9.9 and remove macOS signing logic from package com…
Browse files Browse the repository at this point in the history
…mand
  • Loading branch information
mauro-balades committed Jan 23, 2025
1 parent 6a07b88 commit 64ca9e9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 76 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zen-browser/surfer",
"version": "1.9.8",
"version": "1.9.9",
"description": "Simplifying building firefox forks!",
"main": "index.js",
"bin": {
Expand Down
75 changes: 0 additions & 75 deletions src/commands/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,81 +81,6 @@ export const surferPackage = async () => {
ENGINE_DIR,
true
)

// If we are on macos, run "mach macos-sign" to sign the app and repack it

if ((process as any).surferPlatform == 'darwin') {
log.info('Signing the app')

const dmgFile = (await readdir(join(OBJ_DIR, 'dist'))).find((file) =>
file.endsWith('.dmg')
)
if (!dmgFile) {
log.error('Could not find the dmg file')
return
}

log.debug('Copying the dmg file to the current working directory')
// extract the dmg file
const dmgPath = join(OBJ_DIR, 'dist', dmgFile)

await dispatch(
machPath,
['python', '-m', 'mozbuild.action.unpack_dmg', dmgPath, zenMacDestDir],
ENGINE_DIR,
true
)

log.info('Signing the app')
if (process.env.MACOS_APPLE_DEVELOPER_ID) {
log.info('Preparing the app for signing')
await dispatch(
'chmod',
['+x', '../build/codesign/codesign.bash'],
ENGINE_DIR,
true
)
console.log('Signing the app with the developer id')
await dispatch(
'../build/codesign/codesign.bash',
[
'-a',
join(zenMacDestDir, `${getCurrentBrandName()}.app`),
'-i',
process.env.MACOS_APPLE_DEVELOPER_ID,
'-b',
'../build/codesign/browser.developer.entitlements.xml',
'-p',
'../build/codesign/plugin-container.developer.entitlements.xml',
],
ENGINE_DIR,
true
)
}
log.info('Repacking the app')
const brandingPath = join(ENGINE_DIR, 'browser', 'branding', brandingKey)
await remove(dmgPath)
await dispatch(
machPath,
[
'python',
'-m',
'mozbuild.action.make_dmg',
'--volume-name',
getCurrentBrandName(),
'--icon',
join(brandingPath, 'firefox.icns'),
'--background',
join(brandingPath, 'background.png'),
'--dsstore',
join(brandingPath, 'dsstore'),
zenMacDestDir,
dmgPath,
],
ENGINE_DIR,
true
)
}
}

log.info('Copying results up')
Expand Down

0 comments on commit 64ca9e9

Please sign in to comment.