Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish .d.ts for TypeScript #69

Merged
merged 1 commit into from
May 26, 2024
Merged

Publish .d.ts for TypeScript #69

merged 1 commit into from
May 26, 2024

Conversation

yoursunny
Copy link
Contributor

fixes #68

@james-pre
Copy link
Member

It would be nice if sources could still be published. Perhaps the tsconfig needs root: true?

@yoursunny
Copy link
Contributor Author

src folder is now included in the published archive.
Nevertheless, it would not do anything.

james-pre
james-pre approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@james-pre james-pre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you!

@james-pre james-pre merged commit caf73aa into zen-fs:main May 26, 2024
3 of 4 checks passed
@yoursunny yoursunny deleted the publish-dts branch May 28, 2024 00:00
@james-pre james-pre added the bug Something isn't working label May 29, 2024
@james-pre james-pre added this to the 1.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-pre james-pre james-pre approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Unusable with tight tsconfig
2 participants
@yoursunny @james-pre