Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize recursive option in mkdir and mkdirSync #77

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

yoursunny
Copy link
Contributor

resolves #75

Copy link
Member

@james-pre james-pre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I really appreciate the tests you added. I think the implementations are very difficult to understand, please see my comments on them.

src/emulation/promises.ts Outdated Show resolved Hide resolved
src/emulation/promises.ts Outdated Show resolved Hide resolved
src/emulation/sync.ts Outdated Show resolved Hide resolved
@james-pre james-pre added the bug Something isn't working label Jun 11, 2024
@james-pre james-pre added this to the 1.0 milestone Jun 11, 2024
Renamed `mkdirSingle` to `_mkdirSingle`
(for better performance and readability)
@james-pre
Copy link
Member

james-pre commented Jun 11, 2024

Checks won't run— I think this is the same problem as actions/runner-images#2811. I'm merging without them.

@james-pre james-pre merged commit d26bb5b into zen-fs:main Jun 11, 2024
@james-pre
Copy link
Member

It looks like GitHub Actions is currently experiencing an outage:
image

I'll rerun checks once the outage is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mkdir recursive option is missing
2 participants