fix: ensure we handle null values on description #559
melzrealchecks.yml
on: pull_request
Lint commit messages
1m 3s
Lint JS files
1m 8s
Test
1m 8s
Build
1m 31s
Annotations
10 errors and 14 warnings
|
Lint JS files:
src/modules/service-catalog/components/service-catalog-item/CollapsibleDescription.tsx#L53
'DESCRIPTION_LENGTH_THRESHOLD' is assigned a value but never used
|
|
Lint JS files:
src/modules/service-catalog/components/service-catalog-item/CollapsibleDescription.tsx#L55
Replace `description:·string·|·null·|·undefined` with `⏎··description:·string·|·null·|·undefined⏎`
|
|
Lint JS files:
src/modules/service-catalog/components/service-catalog-item/CollapsibleDescription.tsx#L57
Replace `typeof·description·===·'string'·&&·description.length·>·DESCRIPTION_LENGTH_THRESHOLD` with `(⏎····typeof·description·===·"string"·&&⏎····description.length·>·DESCRIPTION_LENGTH_THRESHOLD⏎··)`
|
|
Lint JS files:
src/modules/service-catalog/components/service-catalog-item/shouldShowToggleButton.spec.js#L1
Replace `'./CollapsibleDescription'` with `"./CollapsibleDescription"`
|
|
|
|
Lint JS files:
src/modules/service-catalog/components/service-catalog-item/shouldShowToggleButton.spec.js#L3
Replace `'shouldShowToggleButton'` with `"shouldShowToggleButton"`
|
|
|
|
Lint JS files:
src/modules/service-catalog/components/service-catalog-item/shouldShowToggleButton.spec.js#L4
Replace `'returns·false·for·empty·string'` with `"returns·false·for·empty·string"`
|
|
|
|
|
|
Lint commit messages
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Lint JS files
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Lint JS files:
src/modules/service-catalog/ServiceCatalogList.tsx#L87
React Hook useEffect has missing dependencies: 'notifyError' and 't'. Either include them or remove the dependency array
|
|
Lint JS files:
src/modules/ticket-fields/fields/Checkbox.tsx#L40
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/CreditCard.tsx#L44
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/DatePicker.tsx#L64
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/DropDown.tsx#L36
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/Input.tsx#L32
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/LookupField.tsx#L184
React Hook useEffect has missing dependencies: 'fetchSelectedOption' and 'value'. Either include them or remove the dependency array
|
|
Lint JS files:
src/modules/ticket-fields/fields/LookupField.tsx#L195
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/MultiSelect.tsx#L64
Do not use hardcoded content as the children of the Span component
|
|
Lint JS files:
src/modules/ticket-fields/fields/Tagger.tsx#L66
Do not use hardcoded content as the children of the Span component
|
|
Test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|