Skip to content

chore: upload translations for service catalog and ticket fields #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: upload translations for service catalog and ticket fields #558

merged 1 commit into from
Jan 7, 2025

Conversation

gosiexon-zen
Copy link
Contributor

Description

Downloaded translations for Service Catalog and Ticket fields module. Marked as obsolete some duplicated translations in New request form module as we moved most of the ticket fields from it so translations for them are in. ticket fields module.

Screenshots

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@gosiexon-zen gosiexon-zen requested review from a team as code owners December 19, 2024 15:10
kubraokcu
kubraokcu reviewed Dec 19, 2024
View reviewed changes
@kubraokcu kubraokcu added the g11n-commented Commented by Globalization label label Dec 19, 2024
@gosiexon-zen gosiexon-zen force-pushed the mbien/translations-for-service-catalog branch from 029695a to 0d2ebe8 Compare December 19, 2024 15:42
@kubraokcu kubraokcu added g11n-approved Approved by Globalization and removed g11n-commented Commented by Globalization label labels Dec 19, 2024
@gosiexon-zen gosiexon-zen force-pushed the mbien/translations-for-service-catalog branch from 0d2ebe8 to ac5dfd8 Compare December 20, 2024 10:07
@gosiexon-zen gosiexon-zen force-pushed the mbien/translations-for-service-catalog branch from ac5dfd8 to 1f4b81a Compare December 20, 2024 10:09
Fredx87
Fredx87 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Fredx87 Fredx87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
With the current setup the translations for the ticket-fields modules are bundled in the ticket-fields-bundle.jsfile, instead of having a separate ticket-fields-translations-bundle.js like the other modules, this is because in the Rollup config the instruction to bundle the translations separately is the last one.

It doesn't seem to be a problem and maybe it is even better because it creates a single bundle instead of two, but it is a bit incoherent with the other modules, but we can eventually revisit it later

@Fredx87 Fredx87 mentioned this pull request Jan 3, 2025
Merged
6 tasks
@gosiexon-zen gosiexon-zen merged commit f34e1af into service-catalog-eap Jan 7, 2025
5 checks passed
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 4.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 4.4.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis-almeida luis-almeida luis-almeida approved these changes

@Fredx87 Fredx87 Fredx87 approved these changes

@kubraokcu kubraokcu kubraokcu approved these changes

Assignees
No one assigned
Labels
g11n-approved Approved by Globalization released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gosiexon-zen @zd-svc-github-copenhagen-theme @luis-almeida @Fredx87 @kubraokcu