Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Add docs for extension config parameter for zend view renderer #664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add docs for extension config parameter for zend view renderer #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/book/v3/features/container/factories.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ It consumes the following `config` structure:
```php
'templates' => [
'layout' => 'name of layout view to use, if any',
'extension' => 'file extension used by templates; defaults to phtml',
'map' => [
// template => filename pairs
],
Expand All @@ -505,6 +506,8 @@ It consumes the following `config` structure:
]
```

- `extension` parameter available since `zendframework/zend-expressive-zendviewrenderer` 2.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the version at the beginning?

Since 2.2.0: extension parameter...

This would be consistent with most version informations in the documentation. Thanks!

Copy link
Member Author

@Xerkus Xerkus Jun 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be confusing since this is zend-expressive documentation and release mentioned is from different package?

Suggested change
- `extension` parameter available since `zendframework/zend-expressive-zendviewrenderer` 2.2.0
- Since ZendViewRenderer 2.2.0: `extension` parameter is used to configure default suffix in NamespacedPathStackResolver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue open for splitting the documentation: #594


When creating the `PhpRenderer` instance, it will inject it with a
`Zend\View\HelperPluginManager` instance (either pulled from the container, or
instantiated directly). It injects the helper plugin manager with custom url and
Expand Down