Remove secrets manager

[strickvl]

This pull request removes the secrets_manager enum and related code from the project. This change is necessary because the secrets_manager functionality is no longer needed and removing it will simplify the codebase.

Secrets manager is removed from the Terraform scripts as well as the stack output files. (Also removed from the enum of valid component types).

Summary by CodeRabbit

• Refactor

  • Removed the Secrets Manager feature across various cloud service modules.

• Documentation

  • Updated comments to reflect changes in the required roles and outputs for enabled services.

• Chores

  • Cleaned up unused variables and output declarations related to the Secrets Manager.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The changes reflect the removal of the Secrets Manager component from an ML stack configuration across various cloud providers (AWS, GCP) and local (k3d) environments. This includes the elimination of related variables, outputs, and configurations within the Terraform modules. Additionally, there are adjustments to other components, such as the experiment tracker, and updates to comments reflecting the current state of enabled services.

Changes

File Path	Change Summary
src/mlstacks/enums.py	Removed SECRETS_MANAGER from ComponentTypeEnum.
src/mlstacks/terraform/.../output_file.tf	Removed blocks for secrets manager, updated experiment tracker blocks.
src/mlstacks/terraform/.../outputs.tf	Removed all outputs related to secrets manager, adjusted other output values.
src/mlstacks/terraform/.../variables.tf	Removed enable_secrets_manager variable.
src/mlstacks/terraform/aws-modular/... src/mlstacks/terraform/gcp-modular/... src/mlstacks/terraform/k3d-modular/...	Similar changes across AWS, GCP, and k3d modules for removing secrets manager and related configurations.
src/mlstacks/terraform/gcp-modular/enable_services.tf	Modified comments on roles, removed Secret Manager service enabling.
src/mlstacks/terraform/gcp-modular/outputs.tf	Updated comments related to model deployer outputs.
src/mlstacks/terraform/k3d-modular/output_stack.tf	Removed secrets manager declarations, added new filename assignment.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[strickvl]

@coderabbitai review

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 92e13d9 and 4583054.

Files selected for processing (9)

• src/mlstacks/enums.py (1 hunks)
• src/mlstacks/terraform/aws-modular/output_file.tf (1 hunks)
• src/mlstacks/terraform/aws-modular/outputs.tf (2 hunks)
• src/mlstacks/terraform/aws-modular/variables.tf (1 hunks)
• src/mlstacks/terraform/gcp-modular/enable_services.tf (1 hunks)
• src/mlstacks/terraform/gcp-modular/output_file.tf (1 hunks)
• src/mlstacks/terraform/gcp-modular/outputs.tf (1 hunks)
• src/mlstacks/terraform/gcp-modular/variables.tf (1 hunks)
• src/mlstacks/terraform/k3d-modular/output_stack.tf (1 hunks)

Files skipped from review due to trivial changes (1)

• src/mlstacks/terraform/gcp-modular/output_file.tf

Additional comments: 8

src/mlstacks/enums.py (1)

• 22-27: The removal of SECRETS_MANAGER from ComponentTypeEnum aligns with the PR's objective to remove the secrets manager functionality. Ensure that this change is reflected wherever ComponentTypeEnum is used throughout the project.

src/mlstacks/terraform/aws-modular/output_file.tf (1)

• 65-67: The removal of the secrets manager block in output_file.tf is consistent with the PR's objective. Ensure that the removal does not affect any dependencies that might expect these outputs.

src/mlstacks/terraform/aws-modular/outputs.tf (1)

• 87-89: The removal of secrets manager outputs in outputs.tf is consistent with the PR's objective. Ensure that the removal does not affect any dependencies that might expect these outputs.

src/mlstacks/terraform/aws-modular/variables.tf (1)

• 7-9: The removal of the enable_secrets_manager variable in variables.tf is consistent with the PR's objective. Ensure that the removal does not affect any dependencies that might expect this variable.

src/mlstacks/terraform/gcp-modular/enable_services.tf (1)

• 6-11: The removal of the Secret Manager service declaration in enable_services.tf is consistent with the PR's objective. Ensure that the removal does not affect any dependencies that might expect this service to be enabled.

src/mlstacks/terraform/gcp-modular/outputs.tf (1)

• 103-105: The removal of secrets manager outputs in outputs.tf is consistent with the PR's objective. Ensure that the removal does not affect any dependencies that might expect these outputs.

src/mlstacks/terraform/gcp-modular/variables.tf (1)

• 7-12: The removal of the enable_secrets_manager variable in variables.tf is consistent with the PR's objective. Ensure that the removal does not affect any dependencies that might expect this variable.

src/mlstacks/terraform/k3d-modular/output_stack.tf (1)

• 87-92: The removal of secrets manager related declarations in output_stack.tf is consistent with the PR's objective. Additionally, the new filename assignment appears correct and should be verified to ensure it aligns with the intended file naming conventions.

[stefannica]

I suggested you use 0.53.1 since we're rolling it out right now, but looks good otherwise.