Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label studio component #154

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

davidrd123
Copy link

@davidrd123 davidrd123 commented Apr 19, 2024

Describe changes

I have created Terraform files in the gcp-modular directory to enable the deployment of a Label Studio component to a Hugging Face Space. This setup works when running terraform apply directly in the directory. However, I encounter issues when attempting to deploy using the mlstacks deploy command.

Debugging Files Included

This PR includes a set of YAML configuration files located in src/mlstacks/testing used for debugging the deployment process of the new MLStacks component. These files are essential for replicating the deployment steps and troubleshooting the issues described.

Steps to Reproduce the Error

To replicate the error I'm encountering with mlstacks deploy, execute the following command from within the src/mlstacks/testing directory:

python ../cli/cli.py deploy -f label_studio_stack.yaml -d

This results in the following error related to Terraform provider resolution:

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider hashicorp/huggingface-spaces: provider registry registry.terraform.io does not have a provider named
registry.terraform.io/hashicorp/huggingface-spaces

Did you intend to use strickvl/huggingface-spaces? If so, you must specify that source address in each module which requires that provider. To see which modules are currently
depending on hashicorp/huggingface-spaces, run the following command:
    terraform providers

Request for Assistance

I would appreciate guidance on resolving the provider resolution issue with mlstacks deploy. Any insights into potential misconfigurations or enhancements to the deployment scripts would be highly beneficial.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation
    accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting
    develop. If your branch wasn't based on develop read
    Contribution guide on rebasing branch to develop.

Types of Changes

  • New Feature: Added Terraform configurations for deploying Label Studio as a component in a Hugging Face Space.
  • Code Refactoring: Introduced new constants and enumerations to support the configuration of the Label Studio component.
  • Bug Fix/Improvement: (If applicable, describe any bug fixes or improvements here.)

…face spaces in the 'gcp-modular' directory - created a 'label-studio-hf-module'. Made changes to add options in constants and enums for the new label studio component, and updated logic to allow 'huggingface' to be accepted as a provider at the component level
Copy link

coderabbitai bot commented Apr 19, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gitguardian bot commented Apr 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

…st creation of the new label studio component
@davidrd123 davidrd123 force-pushed the add-label-studio-component branch from 37882e3 to 5d5b6f5 Compare April 19, 2024 05:25
@strickvl strickvl self-requested a review April 26, 2024 17:43
@strickvl strickvl added the enhancement New feature or request label Apr 26, 2024
@strickvl
Copy link
Contributor

Hi @davidrd123. Apologies for the delay in getting back to you on this. I've tried to fix the provider, but haven't managed to crack it just yet. So for now what I'd propose is the following:

  • assume you can't do anything more than basic usage with the provider, e.g.
resource "huggingface-spaces_space" "zenml_server" {
  name     = "test-zenml-space"
  private  = false
  template = "zenml/zenml"
}
  • remove support in this PR for secrets, variables, hardware, storage and sleep_time

So all this PR would do is spin up the HF space and delete it with default settings. (Plus the option to set it private vs public). It's a more limited feature set, but I can't think of a way to help close out this feature prior to finding the fix for the TF Provider.

Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants