Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kserve and add some fixes #35

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

wjayesh
Copy link
Collaborator

@wjayesh wjayesh commented Feb 9, 2023

  • Version upgraded from 1.6 to 1.9 for kserve terraform module (knative & istio).
  • graceful failure of the kubectl delete command when no resources exist.
  • Add workload identity annotation to kubeflow's pipelin-runner service account.

@strickvl strickvl added enhancement New feature or request internal labels Apr 19, 2023
@strickvl
Copy link
Contributor

@wjayesh what still needs doing for this PR? wondering if we should get it finished or close it?

@wjayesh
Copy link
Collaborator Author

wjayesh commented Sep 27, 2023

I'm not sure if we support kserve any longer. if we do, then we should complete the PR, otherwise close it.
For completing, I think we need to port changes from the kserve-module in this PR to the current kserve module and then test if the deployment works. I'm happy to assist with that but might need at least until next week to get to this.

@strickvl
Copy link
Contributor

mlstacks supports kserve, but zenml no longer supports it, so perhaps we should also drop from mlstacks as well. WDYT? @stefannica ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants