variants: Relocating the overlays #156
Merged
+140
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR relocates board variant overlay files and header files to align with the Arduino repository structure. The changes restructure how overlay files are organized and improve the CMake build system's search logic to locate these files flexibly across different naming conventions.
Changes:
- Add variant-specific overlay files and header files for 7 board variants (rpi_pico, cc3220sf_launchxl, beagleconnect_freedom, arduino_nano_33_iot, arduino_nano_33_ble, arduino_mkrzero)
- Update CMakeLists.txt files in all 10 sample directories to implement an enhanced variant directory search mechanism that supports multiple naming patterns
Reviewed changes
Copilot reviewed 10 out of 22 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| variants/rpi_pico/variant.h | Add copyright header for Raspberry Pi Pico variant |
| variants/rpi_pico/rpi_pico.overlay | Add device tree overlay with GPIO, PWM, and ADC pin configurations for Raspberry Pi Pico |
| variants/cc3220sf_launchxl/variant.h | Add variant header defining LED pin constants for CC3220SF LaunchXL board |
| variants/cc3220sf_launchxl/cc3220sf_launchxl.overlay | Add device tree overlay with GPIO pin mappings for CC3220SF LaunchXL boosterpack |
| variants/beagleconnect_freedom/variant.h | Add variant header defining I2C pin mappings for BeagleConnect Freedom |
| variants/beagleconnect_freedom/beagleconnect_freedom.overlay | Add device tree overlay with extensive GPIO, PWM, and ADC configurations for BeagleConnect Freedom |
| variants/arduino_nano_33_iot/variant.h | Add copyright header for Arduino Nano 33 IoT variant |
| variants/arduino_nano_33_iot/arduino_nano_33_iot.overlay | Add device tree overlay with GPIO, PWM, and ADC configurations for Arduino Nano 33 IoT |
| variants/arduino_nano_33_ble/variant.h | Add copyright header for Arduino Nano 33 BLE variant |
| variants/arduino_nano_33_ble/arduino_nano_33_ble.overlay | Add device tree overlay with GPIO, PWM, and ADC configurations for Arduino Nano 33 BLE |
| variants/arduino_mkrzero/variant.h | Add copyright header for Arduino MKR Zero variant |
| variants/arduino_mkrzero/arduino_mkrzero.overlay | Add device tree overlay with GPIO, PWM, and ADC configurations for Arduino MKR Zero |
| samples/threads_arduino/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/spi_controller/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/serial_event/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/i2cdemo/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/hello_arduino/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/fade/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/button_press_led/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/blinky_arduino/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/attach_interrupt/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
| samples/analog_input/CMakeLists.txt | Update overlay search logic to support flexible variant directory naming patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
If possible, could you also consider adding an SPDX-compatible license (suitable for inclusion in Zephyr) to the files under the variants directory, and ensuring it is clearly stated in the files? > @pillo79 |
soburi
pushed a commit
to soburi/ArduinoCore-zephyr
that referenced
this pull request
Feb 6, 2026
…_setup_readme Update README.md: pre-requirements for macOS and fix flash loader instructions
Contributor
|
Will do, sorry I couldn't add it in time for 0.53.1. |
soburi
force-pushed
the
relocating_overlays
branch
from
06ab039 to
9339e59
Compare
Member
Author
This PR can be merged without waiting for @pillo79 's comment to be addressed. > @DhruvaG2000 |
soburi
force-pushed
the
relocating_overlays
branch
from
9339e59 to
fc372d4
Compare
Directories and filenames are now searched in the following order:
- ${board}_${qualifier}_${revision}
- ${board}_${qualifier}
- ${board}
Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Move the overlay path to match the arduino-repo. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
relocating_overlays
branch
from
fc372d4 to
2122739
Compare
DhruvaG2000
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the overlay path to match the arduino-repo.
We will also improve the search path accordingly.