variants: remove the variant.h #161
Open
+7
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an unnecessary dependency on having empty variant.h files in each variant. Remove this if it's unused and use a default empty one instead. This means we shall only require an overlay when adding new platform support here. update the documentation with this as well Signed-off-by: Dhruva Gole <d-gole@ti.com>
Now there's no requirement to have variant.h in every new variant's folder Signed-off-by: Dhruva Gole <d-gole@ti.com>
DhruvaG2000
changed the title
DhruvaG2000
requested review from
beriberikix,
soburi and
szczys
as code owners
DhruvaG2000
force-pushed
the
remove_variant.h
branch
from
43f6bc3 to
9c95182
Compare
DhruvaG2000
requested review from
beriberikix,
soburi and
szczys
as code owners
soburi
requested changes
Feb 10, 2026
Member
soburi
left a comment
soburi
left a comment
There was a problem hiding this comment.
Please exclude arduino_nano_33_ble, arduino_nano_33_ble_nrf82840_sense and arduino_nano_33_iot because https://github.com/arduino/ArduinoCore-zephyr modified these files. This will probably produce some extra work later.
Others are OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.