-
Notifications
You must be signed in to change notification settings - Fork 25
hal: microchip: Added PIC32CM GC #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
hal: microchip: Added PIC32CM GC #38
Conversation
@NhMchp Can your team review / approve this PR? I will fix the conflicts from the last merge when I'm back in office on Tuesday. |
Please resolve the conflicts, as certain "pic32c" related contents are already merged |
dbbc961
to
e148f37
Compare
e148f37
to
5e7d71c
Compare
this may require a rebase. |
5e7d71c
to
1e3baf2
Compare
@nandojve I rebased the code w/ the changes to README. Should go through now |
4c540b2
to
c759216
Compare
@NhMchp @AzharMCHP Edits have been made, can you re-review? |
Hi @robertperkel , Remember that it is necessary a board in Zephyr side, see this as example: zephyrproject-rtos/zephyr#95480. |
I'm working on a PR for basic support as well for the XPRO board. It's a WIP, but we're getting there |
@NhMchp Can your group re-review and approve? The PRs merged in front of it keep breaking this pull |
9ac0869
to
168462c
Compare
Added dt-binding header files for PIC32CM-JH00 and PIC32CM-JH01 family devices Signed-off-by: Mohamed Azhar <mohamed.azhar@microchip.com>
This commit reorganizes the Microchip HAL directory structure by introducing a top-level packs/ directory. The pic32c/ and sam/ directories have been moved under packs/ to better reflect the hierarchy and maintain consistency. Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
This commit changes the path of pinctrl.h files for sama7g54 and sama7d65 to align with the new Microchip HAL directory structure. Signed-off-by: Tony Han <tony.han@microchip.com>
Added HAL files for PIC32CM GC devices Microchip DFP PIC32CM-GC00 v1.0.27 https://packs.download.microchip.com/Microchip.PIC32CM-GC00_DFP.1.0.27.atpack Signed-off-by: Robert Perkel <robert.perkel@microchip.com>
168462c
to
de1f499
Compare
#define PA0A_EIC_EXTINT0 MCHP_PINMUX(a, 0, a, periph) | ||
|
||
/* pa0adc_test_pad_adc_res_test3 */ | ||
#define PA0ADC_TEST_PAD_ADC_RES_TEST3 MCHP_PINMUX(a, 0, adc_test_pad, periph) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please recheck on these pinmux entries , adc_test_pad,pdmi_test etc
(as this is not handled in your common pinmux header file[mchp_pinctrl_pinmux_pic32c.h] )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where these came from, as the file is autogenerated. I don't see a reason to keep them, should I delete them?
Could you please rebase/resolve conflicts too |
This commit reorganizes the Microchip HAL directory structure by introducing a top-level packs/ directory. The pic32c/ and sam/ directories have been moved under packs/ to better reflect the hierarchy and maintain consistency. Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
Added HAL files for PIC32CM GC devices Microchip DFP PIC32CM-GC00 v1.0.27 https://packs.download.microchip.com/Microchip.PIC32CM-GC00_DFP.1.0.27.atpack Signed-off-by: Robert Perkel <robert.perkel@microchip.com>
…microchip into pic32cm_gc_rel_v01
Added HAL files for PIC32CM GC devices
Note: PIC32CM SG will use the same structure as GC devices, just with different folders