Skip to content

Conversation

robertperkel
Copy link

Added HAL files for PIC32CM GC devices

Note: PIC32CM SG will use the same structure as GC devices, just with different folders

@robertperkel
Copy link
Author

@NhMchp Can your team review / approve this PR?

I will fix the conflicts from the last merge when I'm back in office on Tuesday.

@nandojve nandojve self-assigned this Aug 31, 2025
@AzharMCHP
Copy link
Contributor

Please resolve the conflicts, as certain "pic32c" related contents are already merged

@robertperkel robertperkel force-pushed the pic32cm_gc_rel_v01 branch 2 times, most recently from dbbc961 to e148f37 Compare September 2, 2025 18:23
@nandojve
Copy link
Member

this may require a rebase.

@robertperkel
Copy link
Author

@nandojve I rebased the code w/ the changes to README. Should go through now

@robertperkel robertperkel force-pushed the pic32cm_gc_rel_v01 branch 2 times, most recently from 4c540b2 to c759216 Compare September 16, 2025 18:47
@robertperkel robertperkel requested a review from NhMchp September 18, 2025 15:56
@robertperkel
Copy link
Author

@NhMchp @AzharMCHP Edits have been made, can you re-review?

@nandojve
Copy link
Member

Hi @robertperkel ,

Remember that it is necessary a board in Zephyr side, see this as example: zephyrproject-rtos/zephyr#95480.
You can reuse the drivers and don't forget to add the entries in

https://github.com/zephyrproject-rtos/zephyr/blob/27fa72163203fa3e2d883cdbfcc1fb7ba469e6ed/boards/microchip/pic32c/pic32cm_jh01_cpro/pic32cm_jh01_cpro.yaml#L12

@robertperkel
Copy link
Author

Hi @robertperkel ,

Remember that it is necessary a board in Zephyr side, see this as example: zephyrproject-rtos/zephyr#95480. You can reuse the drivers and don't forget to add the entries in

https://github.com/zephyrproject-rtos/zephyr/blob/27fa72163203fa3e2d883cdbfcc1fb7ba469e6ed/boards/microchip/pic32c/pic32cm_jh01_cpro/pic32cm_jh01_cpro.yaml#L12

I'm working on a PR for basic support as well for the XPRO board. It's a WIP, but we're getting there

@robertperkel
Copy link
Author

@NhMchp Can your group re-review and approve? The PRs merged in front of it keep breaking this pull

AzharMCHP and others added 4 commits September 24, 2025 15:26
Added dt-binding header files for PIC32CM-JH00 and
PIC32CM-JH01 family devices

Signed-off-by: Mohamed Azhar <mohamed.azhar@microchip.com>
This commit reorganizes the Microchip HAL directory structure
by introducing a top-level packs/ directory. The pic32c/ and sam/
directories have been moved under packs/ to better reflect the
hierarchy and maintain consistency.

Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
This commit changes the path of pinctrl.h files for sama7g54 and
sama7d65 to align with the new Microchip HAL directory structure.

Signed-off-by: Tony Han <tony.han@microchip.com>
Added HAL files for PIC32CM GC devices
Microchip DFP PIC32CM-GC00 v1.0.27
https://packs.download.microchip.com/Microchip.PIC32CM-GC00_DFP.1.0.27.atpack

Signed-off-by: Robert Perkel <robert.perkel@microchip.com>
#define PA0A_EIC_EXTINT0 MCHP_PINMUX(a, 0, a, periph)

/* pa0adc_test_pad_adc_res_test3 */
#define PA0ADC_TEST_PAD_ADC_RES_TEST3 MCHP_PINMUX(a, 0, adc_test_pad, periph)
Copy link
Contributor

@AzharMCHP AzharMCHP Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please recheck on these pinmux entries , adc_test_pad,pdmi_test etc
(as this is not handled in your common pinmux header file[mchp_pinctrl_pinmux_pic32c.h] )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where these came from, as the file is autogenerated. I don't see a reason to keep them, should I delete them?

@AzharMCHP
Copy link
Contributor

Could you please rebase/resolve conflicts too

This commit reorganizes the Microchip HAL directory structure
by introducing a top-level packs/ directory. The pic32c/ and sam/
directories have been moved under packs/ to better reflect the
hierarchy and maintain consistency.

Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
Added HAL files for PIC32CM GC devices
Microchip DFP PIC32CM-GC00 v1.0.27
https://packs.download.microchip.com/Microchip.PIC32CM-GC00_DFP.1.0.27.atpack

Signed-off-by: Robert Perkel <robert.perkel@microchip.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants