Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: genpinctrl: Add I3C pin definitions #197

Merged
merged 2 commits into from
Mar 19, 2024
Merged

scripts: genpinctrl: Add I3C pin definitions #197

merged 2 commits into from
Mar 19, 2024

Conversation

SamP20
Copy link
Contributor

@SamP20 SamP20 commented Mar 8, 2024

Introduce support for I3C alternate function.

@SamP20 SamP20 force-pushed the wip/samp/i3c branch 2 times, most recently from 471c712 to aa9db12 Compare March 12, 2024 15:15
erwango
erwango requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I can understand you're working on a STM32 I3C driver ?
This would be a quite welcome addition. Any plans to share it soon ?

Regarding current PR, please make it 2 commits (ie one with the scrit impacts and one with the new signals generated).
Otherwise LGTM

@SamP20
scripts: genpinctrl: Generate I3C pins
ca54443 
Generate I3C pin definitions.

Signed-off-by: Sam Partridge <samp@graphcore.ai>
@SamP20
dts: New batch of pinctrl.dtsi files including I3C signals
2157447 
I3C signals have been generated.

Signed-off-by: Sam Partridge <samp@graphcore.ai>
@SamP20
Copy link
Contributor Author

SamP20 commented Mar 14, 2024

So, I can understand you're working on a STM32 I3C driver ? This would be a quite welcome addition. Any plans to share it soon ?

It's still very much a work in progress. The driver boilerplate and initialisation is mostly finished. I'm currently working on implementing the do_ccc function using interrupts.

Would you be interested in incremental updates in a draft PR? I'll have to check my workplace OSS policies, but I think it should be possible.

Regarding current PR, please make it 2 commits (ie one with the scrit impacts and one with the new signals generated). Otherwise LGTM

All sorted 😄

@erwango erwango merged commit cac0f68 into zephyrproject-rtos:main Mar 19, 2024
4 checks passed
@SamP20 SamP20 deleted the wip/samp/i3c branch March 20, 2024 15:12
@erwango erwango mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamP20 @erwango