Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: remove autoconf.h includes #211

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ycsin
Copy link
Member

@ycsin ycsin commented May 24, 2024

Remove the autoconf.h include from the header template and all the generated files.

See zephyrproject-rtos/zephyr#63973

@henrikbrixandersen
Copy link
Member

Note: This PR must not be merged until zephyrproject-rtos/zephyr#63973 is ready to be merged as well.

@erwango erwango added the DNM label May 24, 2024
@erwango
Copy link
Member

erwango commented Jun 7, 2024

@ycsin Should we merge this PR ?

@ycsin
Copy link
Member Author

ycsin commented Jun 7, 2024

@ycsin Should we merge this PR ?

This is required before the compatibility Kconfig is disabled by default, after this is merged the west.yml should be updated.

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoconf.h can actually be deleted, the defines in it are all injected

@erwango
Copy link
Member

erwango commented Jun 10, 2024

autoconf.h can actually be deleted, the defines in it are all injected

@ycsin Can you update your patch ?

`autoconf.h` should be injected, remove them.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
@erwango erwango merged commit 2d9f676 into zephyrproject-rtos:main Jul 1, 2024
4 checks passed
@str4t0m str4t0m changed the title zephyr: prefix autoconf.h with zephyr/ zephyr: remove autoconf.h includes Jul 1, 2024
@ycsin ycsin deleted the pr/zephyr_headers branch July 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants