lib: stm32wb0: Add BLE controller implementation #236
Conversation
Provide the required license (ST ULTIMATE LIBERTY) to use the binary BLOB. Modify the yaml file to support fetching the STM32WB0 binary stack library for Bluetooth implementation. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
There was a problem hiding this comment.
A README file summing up the origin of the files added would be required.
Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.
Also, to simplify follow up maintenance, I'd expect these files could be updated automatically using existing script. This is not a blocker, but it would be required to have it eventually.
| @@ -70,4 +70,5 @@ if(CONFIG_HAS_STM32LIB) | |||
| target_link_libraries(app PUBLIC stm32wba_ll_lib) | |||
|
|
|||
| endif() | |||
| add_subdirectory_ifdef(CONFIG_BT_STM32WB0 stm32wb0) | |||
There was a problem hiding this comment.
This is fine but we need consistency across vraious libs.
Hence I'd expect the same to be done fro WBA and WB
There was a problem hiding this comment.
I didn't get this comment well. Should I do something?
There was a problem hiding this comment.
You're adding a sub section to handle WB0 case, which is indeed a good idea.
But in that case, for consistency, it would be nice to do the same on other series (in a dedicated commit).
lib/stm32wb0/CMakeLists.txt
Outdated
| zephyr_library_sources(BLE_TransparentMode/Core/Src/stm32wb0x_hal_msp.c) | ||
|
|
||
| else() | ||
| zephyr_compile_definitions(-DCFG_BLE_NUM_RADIO_TASKS=0) |
There was a problem hiding this comment.
Do you expect cases where CONFIG_BT_STM32WB0=y and CONFIG_BT=n ?
Ok, I'll add it.
I will update this file in the future. |
Provide BLE controller implementation for STM32WB0x SOCs. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
Add dedicated CMakeLists.txt for STM32WB and STM32WBA to have consistency with STM32WB0 approach. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
HoZHel
force-pushed
the
stm32wb0_ble_lib
branch
from
126766a
to
4709847
Compare
Done. |
Provide BLE controller implementation for STM32WB0x SOCs.
Provide the required license (ST ULTIMATE LIBERTY) to use the binary BLOB.
Modify the yaml file to support fetching the STM32WB0 binary stack library
for Bluetooth implementation.