-
Notifications
You must be signed in to change notification settings - Fork 166
Replace wget on Windows with built-in curl #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Replace wget on Windows with built-in curl #1016
Conversation
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the reasons why wget
was chosen over curl
initially was that it has a much nicer progress bar showing file name, download size, download speed and remaining time, whereas curl
has a very basic and ugly progress bar that provides none of the aforementioned details.
Given that we recommend and depend on wget
for many other things in the documentation and wget
can be easily installed using winget
alongside many other components that are not available on Windows, I am not convinced that this is a necessary change.
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Understood. The thing is if you want to integrate zephyr setup into your tooling you have other more convenient options to download the rest so then wget would only be required to run this script which is really not necessary. So what about keeping |
If you accept this solution I would also like to add it as option / fallback to macOS as it has also curl installed by default and wget would need to be installed separately. |
The question is: why is it so hard to provide |
Thanks for the clarification! I completely agree that What I’m trying to highlight is that
In contrast, both macOS and Windows already ship with So my suggestion isn’t to drop |
It does actually increase the maintenance overhead for us ensuring the identical behaviour across two different tools and dealing with the potential bug reports related to this.
Also note that you will need a lot more than just |
Since Build
17063
(Win 10) Windows includes a curl distribution. This PR replaces the usage ofwget
with the built-incurl
executable.See https://curl.se/windows/microsoft.html for reference.
@tdewey-rpi @will-v-pi