posix: sysconf: use Z_SC_VAL_IFDEF for sysconf constants #70138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
issues/70136/cannot-build-hello-world-with-sysconf-enabled
branch
from
5946f34
to
625c0d9
Compare
jukkar
previously approved these changes
Mar 13, 2024
yashi
approved these changes
Mar 13, 2024
include/zephyr/posix/unistd.h
Outdated
| @@ -216,7 +216,7 @@ extern "C" { | |||
| #define SIGQUEUE_MAX _POSIX_SIGQUEUE_MAX | |||
| #define STREAM_MAX _POSIX_STREAM_MAX | |||
| #define SYMLOOP_MAX _POSIX_SYMLOOP_MAX | |||
| #define TIMER_MAX CONFIG_MAX_TIMER_COUNT | |||
| #define TIMER_MAX Z_SC_VAL_IFDEF(CONFIG_TIMER, CONFIG_MAX_TIMER_COUNT) | |||
cfriedt
force-pushed
the
issues/70136/cannot-build-hello-world-with-sysconf-enabled
branch
from
625c0d9
to
94b4f25
Compare
yashi
approved these changes
Mar 13, 2024
jukkar
previously approved these changes
Mar 13, 2024
Previously, CONFIG_MAX_TIMER_COUNT and CONFIG_MSG_COUNT_MAX were used without checking if CONFIG_TIMER and CONFIG_POSIX_MQUEUE were enabled. Use Z_SC_VAL_IFDEF() to conditionally define those constants based on their gating Kconfig values, otherwise, they are defined to -1. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
force-pushed
the
issues/70136/cannot-build-hello-world-with-sysconf-enabled
branch
from
94b4f25
to
dcde1e5
Compare
ycsin
approved these changes
Mar 13, 2024
jukkar
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CONFIG_MAX_TIMER_COUNT and CONFIG_MSG_COUNT_MAX were used without checking if CONFIG_TIMER and CONFIG_POSIX_MQUEUE were enabled.
Use Z_SC_VAL_IFDEF() to conditionally define those constants based on their gating Kconfig values, otherwise, they are defined to -1.
Partially
Fixes #70136