west.yml: hal_stm32: Don't include legacy headers anymore #73214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_stm32
DNM
We're not supposed to rely on symbols provided by these files. In case it is required stm32 zephyr code base should be updated rather than relying on legacy definitions. Additionally: Fixes zephyrproject-rtos#70136 Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
erwango
force-pushed
the
hal_stm32_remove_legacy_includes
branch
from
94ba7fa
to
8f884ca
Compare
ajarmouni-st
approved these changes
May 27, 2024
gautierg-st
approved these changes
May 27, 2024
|
Woops, issue on my side, I've pushed the STM32 HAL SHA1 of #73208 on this one, which removed the Do No Merge... No major issue I think, but I'll push a new PR to point to the right HAL PR. |
|
Due to a PR reference mix up: This PR actually got hal point to Legacy Ethernet API removal: zephyrproject-rtos/hal_stm32@366c5c9 Actual PR for legacy headers cleanup: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not supposed to rely on symbols provided by these files. In case it is required stm32 zephyr code base should be updated rather than relying on legacy definitions.
Additionally:
Fixes #70136
Note:
See last comment