-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
west.yml: stm32: Remove PAGESIZE definition #74428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_stm32
DNM
This PR should not be merged (Do Not Merge)
labels
Jun 17, 2024
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it. Note: This is a second fix for zephyrproject-rtos#73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
This was referenced Jun 20, 2024
cfriedt
approved these changes
Jun 20, 2024
nashif
approved these changes
Jun 21, 2024
besmarsh
added a commit
to besmarsh/zephyr
that referenced
this pull request
Jun 25, 2024
The POSIX macros ATEXIT_MAX, PAGE_SIZE, and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. This commit defines ATEXIT_MAX, PAGE_SIZE, and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
besmarsh
added a commit
to besmarsh/zephyr
that referenced
this pull request
Jul 8, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE, and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
besmarsh
added a commit
to besmarsh/zephyr
that referenced
this pull request
Jul 8, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
aescolar
pushed a commit
that referenced
this pull request
Jul 10, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See #74623 and #74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
AlienSarlak
pushed a commit
to AlienSarlak/zephyr
that referenced
this pull request
Jul 13, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
CZKikin
pushed a commit
to nxp-upstream/zephyr
that referenced
this pull request
Jul 18, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
Devansh0210
pushed a commit
to Devansh0210/zephyr
that referenced
this pull request
Jul 20, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
Thalley
pushed a commit
to Thalley/zephyr
that referenced
this pull request
Aug 1, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. Signed-off-by: Ben Marsh <ben.marsh@helvar.com>
Chenhongren
pushed a commit
to Chenhongren/zephyr
that referenced
this pull request
Aug 26, 2024
The POSIX macros PAGE_SIZE and PAGESIZE (queriable through sysconf()) were conditionally defined only if an existing definition did not already exist. These should be defined unconditionally in their header to ensure they get the correct values. If these macros are defined elsewhere with a different meaning, that's a problem. There was an issue where PAGESIZE was already defined with a different meaning. See zephyrproject-rtos#74623 and zephyrproject-rtos#74428. The POSIX macro ATEXIT_MAX is also conditionally defined and should be unconditionally defined, but there is currently a definition in picolibc (picolibc/newlib/libc/include/stdlib.h) so this change will be done separately. This commit defines PAGE_SIZE and PAGESIZE unconditionally. (cherry picked from commit 8c0d3de) Original-Signed-off-by: Ben Marsh <ben.marsh@helvar.com> GitOrigin-RevId: 8c0d3de Change-Id: Icb9ff7549525906d976333b9327e3b7dd42975b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5692888 Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> Tested-by: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAGESIZE definition from legacy.h conflicts with POSIX definition. Since this definition comes from legacy.h file which is only there for Cube backward compatibility that we don't maintain in Zephyr, simply remove it.
Note:
This is a second fix for #73363 which wasn't sufficiently tested. Legacy file is included in stm32yyxx_hal_def.h headers and actually removing it generates build errors as we're relying on some of the definitions. Removing this inclusion is necessary and will be done but on next release.
Fixes #73896