Make cavstool code more shareable #78753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
nashif,
softwarecki and
tmleman
|
The PR requiring this change is here: thesofproject/sof#9498 |
jsarha
force-pushed
the
make_cavstool_shareable
branch
from
320abec
to
130d66e
Compare
kv2019i
previously approved these changes
Sep 24, 2024
jsarha
force-pushed
the
make_cavstool_shareable
branch
from
130d66e
to
b037c13
Compare
|
Fix couple of pylint issues for CI compliance checks. |
added 4 commits
September 25, 2024 12:40
Do not force argsparse code to all modules importing cavstool.py. The commit moves argparse code into a separate function, and calls it from 'if __name__ == "__main__":'. Also adds the argsparse call to to acetool.py that shares cavstool code with the argument parsing. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
map_reg() depends on args global variable for knowing it should load a new firmware or just stand by for logging or Zephyr shell. The map_regs() code is the very first step to access the DSP memory, it nees to be shareable if the code is to be accessed from another python module. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
…ed() The fw_is_alive() depends on 'dsp' global variable which is assigned from map_regs() return value. To make fw_is_alive() and wait_fw_entered(), that calls fw_is_alive(), callable from another module, the 'dsp' variable needs to be passed as an argument. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Add debug_slot_offset() function for getting a debug slot offset by the slot number. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
force-pushed
the
make_cavstool_shareable
branch
from
b037c13
to
c3e7082
Compare
And one more. |
dcpleung
approved these changes
Sep 25, 2024
kv2019i
approved these changes
Sep 26, 2024
lgirdwood
approved these changes
Oct 1, 2024
andyross
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Seems clean enough, though I absolutely agree that this has grown beyond the original organization and maybe a rewrite might be worth thinking about. Note that MediaTek DSPs have a broadly similar MMIO interface to device SRAM, and it would be good for them to evolve in the direction of sharing the same host-side log code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cavstool.py has a lot of useful but complex code in it to access DSP memory, but it looks to be grown quite hard to maintain. This PR makes some critical changes there to make some of the functions in cavstool.py shareable from outside the module to avoid growing it even more or forking the code. Much more could be done to that direction, but since I do not understand too well what it is doing, I am proceeding in baby steps and doing only what I need.
The motivation to these changes is to allow debug_stream.py [1] from SOF side to access its debug window slot directly using cavstool.py functions.
[1] https://github.com/thesofproject/sof/blob/main/tools/debug_stream/debug_stream.py