drivers: sensor: Add Vishay VEML6031 Ambient Light Sensor #84563
+1,039
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
kartben,
MaureenHelm,
nashif,
teburd,
tristan-google,
ubieda and
yperess
it-klinger
force-pushed
the
add-veml6031
branch
3 times, most recently
from
1837154 to
739762c
Compare
MaureenHelm
reviewed
Jan 27, 2025
Comment on lines
+26
to
+27
| This sample uses the VEML6031 sensor controlled using the I2C-2 interface at | ||
| the Olimex-STM32-E407 board on feather PF0 and PF1. |
There was a problem hiding this comment.
Is there a feather board available with this sensor or did you hand-wire something up?
There was a problem hiding this comment.
I got the sensor on a breakout board from the vendor Vishay and connected it manually to the Olimex board.
|
Add this sensor to |
it-klinger
force-pushed
the
add-veml6031
branch
3 times, most recently
from
65867d2 to
cf4fd60
Compare
yperess
requested changes
Jan 28, 2025
it-klinger
force-pushed
the
add-veml6031
branch
from
cf4fd60 to
ea8df30
Compare
yperess
requested changes
Jan 29, 2025
it-klinger
force-pushed
the
add-veml6031
branch
from
ea8df30 to
eb29e71
Compare
yperess
previously approved these changes
Jan 30, 2025
MaureenHelm
requested changes
Feb 5, 2025
Comment on lines
694
to
697
| test_i2c_veml6031: veml6031@29 { | ||
| compatible = "vishay,veml6031"; | ||
| reg = <0x29>; | ||
| }; |
There was a problem hiding this comment.
This needs to go at the end of the file with an I2C bus address incremented by one from the previous node. This is a build-only test so the address doesn't need to match the datasheet.
samples/sensor/veml6031/prj.conf
Outdated
Comment on lines
2
to
7
| CONFIG_GPIO=y | ||
| CONFIG_SHELL=y | ||
| CONFIG_I2C=y | ||
| CONFIG_I2C_STM32=y | ||
| CONFIG_SENSOR=y | ||
| CONFIG_SENSOR_SHELL=y |
There was a problem hiding this comment.
Most of these Kconfigs aren't needed.
Suggested change
| CONFIG_GPIO=y | |
| CONFIG_SHELL=y | |
| CONFIG_I2C=y | |
| CONFIG_I2C_STM32=y | |
| CONFIG_SENSOR=y | |
| CONFIG_SENSOR_SHELL=y | |
| CONFIG_SENSOR=y |
There was a problem hiding this comment.
Thanks for the reviews.
it-klinger
force-pushed
the
add-veml6031
branch
from
eb29e71 to
e50af49
Compare
- add driver for Vishay VEML6031 High Accuracy Ambient Light Sensor. - add new compatible "vishay,veml6031". - read and write consecutive 8 bit registers as bulk operation. - add driver to build all test of sensors. - support fetch and get. - triggered mode and interrupt is not yet supported. Signed-off-by: Andreas Klinger <ak@it-klinger.de>
- Test all attribute combinations of Vishay sensor VEML6031 which is an ambient light sensor. - Print out saturation case of sensor. - Idea is to be able to find a good combination of attributes for an optimal working area. Signed-off-by: Andreas Klinger <ak@it-klinger.de>
it-klinger
force-pushed
the
add-veml6031
branch
from
e50af49 to
7f1fccb
Compare
yperess
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VEML6031 Sensor driver:
Sample application:
ambient light sensor.
optimal working area.