drivers: rtc: Add Maxim DS1337 RTC driver #85015
Open
+798
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bjarki-andreasen,
galak,
MaureenHelm,
microbuilder,
ozersa and
ttmut
Lefucjusz
force-pushed
the
add_ds1337_rtc_driver
branch
from
9c87d36 to
0dd19f1
Compare
bjarki-andreasen
previously approved these changes
Feb 3, 2025
kartben
requested changes
Feb 3, 2025
drivers/rtc/rtc_ds1337.c
Outdated
Comment on lines
510
to
513
| timeptr->tm_mday = bcd2bin(regs[2] & DS1337_ALARM_DATE_MASK); | ||
| *mask |= RTC_ALARM_TIME_MASK_MONTHDAY; | ||
| } else { | ||
| timeptr->tm_wday = bcd2bin(regs[2] & DS1337_ALARM_DAY_MASK); |
There was a problem hiding this comment.
Suggested change
| timeptr->tm_mday = bcd2bin(regs[2] & DS1337_ALARM_DATE_MASK); | |
| *mask |= RTC_ALARM_TIME_MASK_MONTHDAY; | |
| } else { | |
| timeptr->tm_wday = bcd2bin(regs[2] & DS1337_ALARM_DAY_MASK); | |
| timeptr->tm_mday = bcd2bin(regs[3] & DS1337_ALARM_DATE_MASK); | |
| *mask |= RTC_ALARM_TIME_MASK_MONTHDAY; | |
| } else { | |
| timeptr->tm_wday = bcd2bin(regs[3] & DS1337_ALARM_DAY_MASK); |
drivers/rtc/rtc_ds1337.c
Outdated
Comment on lines
432
to
435
| } else if (mask & RTC_ALARM_TIME_MASK_WEEKDAY) { | ||
| regs[3] = bin2bcd(timeptr->tm_wday) & DS1337_ALARM_DAY_MASK; | ||
| regs[3] |= DS1337_DY_DT_MASK; | ||
| } else { |
There was a problem hiding this comment.
need to apply DS1337_DAY_OFFSET?
Suggested change
| } else if (mask & RTC_ALARM_TIME_MASK_WEEKDAY) { | |
| regs[3] = bin2bcd(timeptr->tm_wday) & DS1337_ALARM_DAY_MASK; | |
| regs[3] |= DS1337_DY_DT_MASK; | |
| } else { | |
| } else if (mask & RTC_ALARM_TIME_MASK_WEEKDAY) { | |
| regs[3] = bin2bcd(timeptr->tm_wday - DS1337_DAY_OFFSET) & DS1337_ALARM_DAY_MASK; | |
| regs[3] |= DS1337_DY_DT_MASK; | |
| } else { |
There was a problem hiding this comment.
You're right! Fixed
drivers/rtc/rtc_ds1337.c
Outdated
Comment on lines
670
to
676
| if (reg_val & DS1337_A1F_MASK) { | ||
| LOG_WRN("Alarm 0 might have been missed!"); | ||
| } | ||
| if (reg_val & DS1337_A2F_MASK) { | ||
| LOG_WRN("Alarm 1 might have been missed!"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (reg_val & DS1337_A1F_MASK) { | |
| LOG_WRN("Alarm 0 might have been missed!"); | |
| } | |
| if (reg_val & DS1337_A2F_MASK) { | |
| LOG_WRN("Alarm 1 might have been missed!"); | |
| } | |
| if (reg_val & DS1337_A1F_MASK) { | |
| LOG_WRN("Alarm 1 might have been missed!"); | |
| } | |
| if (reg_val & DS1337_A2F_MASK) { | |
| LOG_WRN("Alarm 2 might have been missed!"); | |
| } |
There was a problem hiding this comment.
I was not sure whether I should refer to the alarms by RTC numbering or by IDs passed to alarm API functions, corrected as per your suggestion
This PR adds support for Maxim Integrated DS1337 RTC chip. Supported functionalities: * Alarm interrupt (both alarms trigger INTA pin) * Time setting/reading * Both alarms setting/reading * SQW frequency configuration Tested on nRF52833-DK using rtc_api test set. Signed-off-by: Marcin Lyda <elektromarcin@gmail.com>
Lefucjusz
force-pushed
the
add_ds1337_rtc_driver
branch
from
0dd19f1 to
6fd24cc
Compare
kartben
approved these changes
Feb 3, 2025
|
Btw @Lefucjusz since you mentioned you'd actually tested this, it would be good to see if there is anything that could be improved to have better coverage, or if there are tests that need to be fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Maxim Integrated
DS1337 RTC chip.
Supported functionalities:
Tested on nRF52833-DK using rtc_api test set.