Bluetooth: Audio: Fix coverity issue with notifications #85058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a common function to get the maximum notification size, instead of having multiple implementations of this. Ideally this function should be moved to the GATT API, but for now just implement it for LE audio and then move to GATT later. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
audio_ntf_fixes
branch
from
ffbfb58 to
eaf922e
Compare
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
Instead of providing NULL for bt_gatt_notify_uuid we iterate on the connection objects and ensure that we properly truncate the notification based on each connection's GATT MTU. This ensures that we send the right size for all connections. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
audio_ntf_fixes
branch
from
eaf922e to
aa332a3
Compare
cvinayak
approved these changes
Feb 14, 2025
kartben
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84684
Fixes #84685
Fixes #84735
Fixes #84748