Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce siwg917 #85144

Merged
merged 25 commits into from
Feb 11, 2025
Merged

Introduce siwg917 #85144

merged 25 commits into from
Feb 11, 2025

Conversation

jerome-pouiller
Copy link
Contributor

@jerome-pouiller jerome-pouiller commented Feb 4, 2025 •
edited
Loading

Add support for Silicon Labs SiWx91x series.

Note for archeologists: This code has been maintained for a few months in the Silicon Labs downstream repository.
It couldn't be merged before because of a license issue in WiseConnect 3.3 (a component of the hal_silabs). This problem has been fixed since this code now depends on WiseConnect 3.4.
This is the reason why several commits has Co-authors.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 4, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@df3414d zephyrproject-rtos/hal_silabs@2e64a70 zephyrproject-rtos/hal_silabs@df3414d5..2e64a70d

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_silabs DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025
@fabiobaltieri fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025
@jerome-pouiller jerome-pouiller force-pushed the introduce-siwg917 branch 5 times, most recently from 023300b to 0a60cf9 Compare February 4, 2025 17:59
@jhedberg jhedberg added the platform: Silabs Silicon Labs label Feb 4, 2025
asmellby
asmellby reviewed Feb 5, 2025
View reviewed changes
boards/silabs/radio_boards/siwx917_rb4338a/doc/index.rst Outdated
Flashing
========

Applications for the ``siwx917_rb4338`` board target can be built in the usual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a from board name here, and consistently in the rest of the Flashing section.

@jerome-pouiller
Copy link
Contributor Author

v2:

  • replace pow(2, x) by (1 << x)
  • get rid of dependency on sscanf()
  • get rid of dependency on sys/socket.h

@jerome-pouiller
Copy link
Contributor Author

jerome-pouiller commented Feb 5, 2025 •
edited
Loading

v3:

  • s/siwx917_rb4338/siwx917_rb4338a/

@jerome-pouiller jerome-pouiller force-pushed the introduce-siwg917 branch 4 times, most recently from 1ce43ba to f60bbc9 Compare February 5, 2025 20:41
@jerome-pouiller
Copy link
Contributor Author

v4:

  • Only keep minimal features in siwx917_rb4338a_defconfig
  • Fix issue with <sys/select.h>
  • Fix issue with TIMERS
  • Remove useless RS1xxxx.h

@jerome-pouiller jerome-pouiller marked this pull request as ready for review February 5, 2025 21:52
jerome-pouiller and others added 3 commits February 11, 2025 11:39
@jerome-pouiller
boards: silabs: Add support for Silabs SiWx917 BRD4338 board
bf7abb7 
This new board definition allow to test Silicon Labs SiWx917 SoC.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @asmellby
drivers: pinctrl: Introduce support for SiWx91x
6b3b77d 
This device is included on Silabs SiWx91x series. The current driver is
able to manage "High Power" and "Ultra Low Power" pins.

Co-authored-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
boards: silabs: siwx91x: Add support for pinctrl
6ef9099 
Report pinctrl configuration in the board definitions.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
jerome-pouiller and others added 18 commits February 11, 2025 13:05
@jerome-pouiller @asmellby
drivers: gpio: Introduce support for SiWx91x
5c4ed87 
Implement GPIO driver for Siliconlab SiWx917 family.

This driver support high Performance (HP), Ultra Low Power (ULP) and
Ultra Ultra Low Power (UULP) GPIOs.

Co-authored-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
boards: silabs: siwx91x: Add support for GPIOs
3a83377 
Report gpio configuration in the board definitions.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
tests: drivers: gpio: Enable board siwx917_rb4338a
e1e6b2c 
Ensure nobody break compatibility with SiWx91x chipsets.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @silabs-TiborL
drivers: entropy: Introduce SiWx91x entropy driver
b2ef0a3 
Support for random number generator is required for most of the
cryptographic operations, including support for WiFi and TLS.

This driver has been tested with tests/drivers/entropy:

    *** Booting Zephyr OS build v3.7.0-4339-g1ec5ce05f9f8 ***
    Running TESTSUITE entropy_api
    ===================================================================
    START - test_entropy_get_entropy
    random device is 0x8217298, name is rng@45090000
      0x93
      0x3e
      0xf1
      0x68
      0xd4
      0x22
      0xbf
      0x4d
      0xad
     PASS - test_entropy_get_entropy in 0.012 seconds
    ===================================================================
    TESTSUITE entropy_api succeeded

    ------ TESTSUITE SUMMARY START ------

    SUITE PASS - 100.00% [entropy_api]: pass = 1, fail = 0, skip = 0 ...
     - PASS - [entropy_api.test_entropy_get_entropy] duration = 0.01 ...

    ------ TESTSUITE SUMMARY END ------

    ===================================================================
    RunID: d1547c805699201af769cb01331efcce
    PROJECT EXECUTION SUCCESSFUL

Co-authored-by: Tibor Laczko <tibor.laczko@silabs.com>
Signed-off-by: Tibor Laczko <tibor.laczko@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
boards: silabs: siwx91x: Add support for hardware RNG
80bb9dd 
Report entropy configuration in the board definitions.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
drivers: dma: Introduce support for SiWx91x
bb205c8 
Implement DMA driver for siwx917 using UDMA peripheral. For now,
Scatter/Gather DMA is not yet supported.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @smalae
boards: silabs: siwx91x: Add support for DMAs
c1161b0 
Report DMA configuration in the board definitions.

Note the addresses of the DMA buffers are hardcoded in the HAL. So,
these areas have to be declared in the linker file.

Co-authored-by: Sai Santhosh Malae <santhosh.malae@silabs.com>
Signed-off-by: Sai Santhosh Malae <santhosh.malae@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
tests: drivers: dma: Enable board siwx917_rb4338a
0614504 
Ensure nobdy break compatibility with SiWx91x chipsets.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @silabs-TiborL
soc: silabs: siwg917: Initialize the NWP
ff58656 
Network Processor (NWP) is used to run WiFi, Bluetooth and Flash
drivers.

Co-authored-by: Tibor Laczko <tibor.laczko@silabs.com>
Signed-off-by: Tibor Laczko <tibor.laczko@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @Martinhoff-maker
drivers: flash: Introduce SiWx91x Flash driver
2a947d0 
Add flash driver for Silicon Labs SiWx91x family.

Co-authored-by: Martin Hoff <martin.hoff@silabs.com>
Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @Martinhoff-maker
boards: silabs: siwx91x: Add support for Flash
52f54e8 
A specific section of the flash on the SiWx917 is reserved for the
Network co-processor (NWP). This zone needs to be delimited in order to
not overwrite it. We then need to use "code-partition" to provide Zephyr
the application code flash location.

Co-authored-by: Martin Hoff <martin.hoff@silabs.com>
Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
tests: drivers: flash: Enable board siwx917_rb4338a
5b67f8d 
Ensure nobdy break compatibility with SiWx91x chipsets.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller @silabs-TiborL
drivers: bluetooth: Introduce SiWx91x HCI driver
53688c0 
Driver was tested with a custom application which enabled the BT_SHELL.
Basic functionalities were verified:
 - Scanning
 - Advertising
 - Connecting

Configuration needed for the test:
 - CONFIG_BT=y
 - CONFIG_BT_PERIPHERAL=y
 - CONFIG_BT_CENTRAL=y
 - CONFIG_BT_SHELL=y
 - CONFIG_SHELL=y

Co-authored-by: Tibor Laczko <tibor.laczko@silabs.com>
Signed-off-by: Tibor Laczko <tibor.laczko@silabs.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
boards: silabs: siwx91x: Add support for Bluetooth
c104de2 
Report Bluetooth HCI declaration in the board definitions.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
drivers: wifi: Introduce SiWx91x WiFi driver
a332e4a 
This driver allow to use Zephyr native IP stack or the IP stack provided
by HAL / WiseConnect.

The WiseConnect implementation may take advantage of the specific
features provided by the 917 (power consumption, speed,
validation...).

Some notable features are not available with this interface:
  - It seems Zephyr does not provide API to offload multicast membership
    management. User should be to directly call WiseConnect APIs
  - Support for ICMP frames is difficult. Note that WiseConnect
    automatically answer to ping request. It is just not possible to
    send ping requests and receive ping responses.
  - Zephyr and WiseConnect both support TLS offloading. However this
    patch does not implement it.
  - Reentrancy in the WiseConnect side is uncertain.

This implementation has been tested with samples/net/wifi/ (which relies
on subsys/net/lib/shell).

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
boards: silabs: swix91x: Add support for Wifi
f972a2c 
Report WiFi declaration in the board definitions.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
tests: drivers: wifi: Enable board siwx917_rb4338a
2806041 
Ensure nobdy break compatibility with SiWx91x chipsets.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@jerome-pouiller
boards: silabs: siwx91x: Add support for si7021 sensor
e63e59b 
Report configuration of the Si7021 in the board definitions.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
@kartben kartben merged commit f63c611 into zephyrproject-rtos:main Feb 11, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@asmellby asmellby asmellby approved these changes

@nordicjm nordicjm nordicjm approved these changes

@jukkar jukkar jukkar left review comments

@Martinhoff-maker Martinhoff-maker Martinhoff-maker left review comments

@de-nordic de-nordic Awaiting requested review from de-nordic

@gmarull gmarull Awaiting requested review from gmarull

@Kludentwo Kludentwo Awaiting requested review from Kludentwo

@krish2718 krish2718 Awaiting requested review from krish2718

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@mnkp mnkp Awaiting requested review from mnkp

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@rlubos rlubos Awaiting requested review from rlubos

@teburd teburd Awaiting requested review from teburd

@yonsch yonsch Awaiting requested review from yonsch

Assignees

@jhedberg jhedberg

@jukkar jukkar

@asmellby asmellby

Labels
manifest manifest-hal_silabs platform: Silabs Silicon Labs
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
9 participants
@jerome-pouiller @zephyrbot @jhedberg @jukkar @asmellby @nordicjm @Martinhoff-maker @kartben @fabiobaltieri