twister: extend reason field in Twister reports #85393
Merged
+98
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
golowanow,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
nashif
previously approved these changes
Feb 7, 2025
gchwier
force-pushed
the
grch-twister-extend-reason
branch
from
e5b73b1 to
d9c97b6
Compare
nashif
previously approved these changes
Feb 9, 2025
hakehuang
previously approved these changes
Feb 10, 2025
gchwier
force-pushed
the
grch-twister-extend-reason
branch
from
d9c97b6 to
80f2790
Compare
Extended the reason field in Twister report to include more detailed information for 'Build failure' and 'CMake build failure' Signed-off-by: Grzegorz Chwierut <grzegorz.chwierut@nordicsemi.no>
Updated test_report_summary to match new string with detailed reason of build failure. Signed-off-by: Grzegorz Chwierut <grzegorz.chwierut@nordicsemi.no>
After adding more detailed information to the reason field in Twister report, update twister_report_analyzer.py to group CMake and Build failures. Signed-off-by: Grzegorz Chwierut <grzegorz.chwierut@nordicsemi.no>
gchwier
force-pushed
the
grch-twister-extend-reason
branch
from
80f2790 to
46651b7
Compare
nashif
approved these changes
Feb 11, 2025
PerMac
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
LGTM. Just one remark. This introduces some code duplication: the same analysis is in twister and twister_report_analyzer.py script. I don't mind it for now since such functionality is very new and we don't know yet how it will be used later on. To remove code duplication in future twister could e.g. import the analysis method from the analyzer script.
hakehuang
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the reason field in Twister report to include more detailed information for 'Build failure' and
'CMake build failure'
Added parsing of specific error keys from logs to provide clearer context in the reports.
Requested here: https://discord.com/channels/720317445772017664/733037890514321419/1337400203019550786
To test you can modify hello_world sample, e.g.:
and run:
$ZEPHYR_BASE/scripts/twister -vv -T samples/hello_world -p native_sim -ll debugthen you will find more details in
reasonfield in twister.json (and inmessagefield in junit reports).