Skip to content

boards: adafruit: esp32s2_feather: add support #85405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

boards: adafruit: esp32s2_feather: add support #85405

merged 1 commit into from
Mar 27, 2025

Conversation

DBS06
Copy link
Contributor

@DBS06 DBS06 commented Feb 7, 2025 •
edited
Loading

This PR adds board support for the Adafruit ESP32-S2 Feather development boards with different flavors:

  • adafruit_feather_esp32s2@B
  • adafruit_feather_esp32s2@C
  • adafruit_feather_esp32s2_tft
  • adafruit_feather_esp32s2_tft_reverse

This is basically inspired by #75844 and other boards i.e. pinout, feather connector, fuel gauge and on-board NeoPixel. There is an issue #68512 requesting support for this board.

I had to reopen this PR because I messed up the original branch

@zephyrbot zephyrbot added area: Display area: Samples Samples area: LED Label to identify LED subsystem area: Sensors Sensors labels Feb 7, 2025
@DBS06 DBS06 force-pushed the add_adafruit_feather_esp32s2_boards branch 4 times, most recently from 25de373 to 0c39d53 Compare February 11, 2025 10:41
@DBS06 DBS06 mentioned this pull request Feb 12, 2025
Closed
@DBS06
Copy link
Contributor Author

DBS06 commented Feb 13, 2025 •
edited
Loading

Hi, how do I add further labels: like area:Boards and platform:ESP32?

nordicjm
nordicjm requested changes Mar 11, 2025
View reviewed changes
@DBS06
Copy link
Contributor Author

DBS06 commented Mar 17, 2025

Minor nit. Changes OK

Thanks a lot!

@DBS06
Copy link
Contributor Author

DBS06 commented Mar 17, 2025

@kartben zephyrbot added the reviewers again which you already removed. Many thanks in advance! 😉

@DBS06
Copy link
Contributor Author

DBS06 commented Mar 17, 2025 •
edited
Loading

I just saw that the esp32s3 feather (#75844) was merged last week and I have one question regarding this:

  • @leonrinkel created 2 different board folders for one board with different "flavors" (lets call it this way), both boards (the Adafruit ESP32-S3 Feather and Adafruit ESP32-S3 Feather TFT) have more or less the same base and differs in features like On-Board-TFT and slightly different pinouts). Furthermore I saw that the Adafruit ESP32-S3 Reverse TFT Feather is currently not supported.
  • I created one board folder for 3 different targets (actually 4, because the Adafruit Feather ESP32-S2 has two revisions)

Which approach is the preferred way to go?

nordicjm
nordicjm previously approved these changes Mar 18, 2025
View reviewed changes
sylvioalves
sylvioalves previously approved these changes Mar 18, 2025
View reviewed changes
@DBS06 DBS06 dismissed stale reviews from sylvioalves and nordicjm via ca06da6 March 27, 2025 09:10
@DBS06 DBS06 force-pushed the add_adafruit_feather_esp32s2_boards branch from f8799f4 to ca06da6 Compare March 27, 2025 09:10
@DBS06 DBS06 requested review from nordicjm and sylvioalves March 27, 2025 09:10
@DBS06
Copy link
Contributor Author

DBS06 commented Mar 27, 2025

@kartben @sylvioalves @nordicjm rebased the branch and added a startup-delay-us = <10>; for the i2c_reg (is a power-domain-gpio) because I detected, that some I2C devices need some time to settle down after powering up.

@kartben
Copy link
Contributor

kartben commented Mar 27, 2025

@kartben @sylvioalves @nordicjm rebased the branch and added a startup-delay-us = <10>; for the i2c_reg (is a power-domain-gpio) because I detected, that some I2C devices need some time to settle down after powering up.

cool - I'm splitting up the doc pages in 3 as briefly discussed on discord - will push an update to your branch shortly

@DBS06
Copy link
Contributor Author

DBS06 commented Mar 27, 2025

@kartben @sylvioalves @nordicjm rebased the branch and added a startup-delay-us = <10>; for the i2c_reg (is a power-domain-gpio) because I detected, that some I2C devices need some time to settle down after powering up.

cool - I'm splitting up the doc pages in 3 as briefly discussed on discord - will push an update to your branch shortly

Awesome! thanks a lot!

@DBS06 @kartben
boards: adafruit: esp32s2_feather: add support
fa6bba6 
add board support for adafruit_esp32s2_feather board series

Signed-off-by: Philipp Steiner <philipp.steiner1987@gmail.com>
@kartben kartben force-pushed the add_adafruit_feather_esp32s2_boards branch from ca06da6 to fa6bba6 Compare March 27, 2025 09:59
@kartben
Copy link
Contributor

kartben commented Mar 27, 2025

@DBS06 please check I didn't mess anything up :)

@DBS06
Copy link
Contributor Author

DBS06 commented Mar 27, 2025

@kartben LGTM 👍 Thanks for your help!

kartben
kartben approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for docs ;)

@kartben kartben merged commit 5ef4e8a into zephyrproject-rtos:main Mar 27, 2025
22 checks passed
@DBS06 DBS06 deleted the add_adafruit_feather_esp32s2_boards branch March 28, 2025 06:10
This was referenced Apr 24, 2025
Merged
Closed
Merged
@kartben kartben linked an issue May 22, 2025 that may be closed by this pull request
Add Support for Adafruit ESP32-S3 and ESP32-S2 Feather Boards #68512
Closed
@DBS06 DBS06 mentioned this pull request Jun 17, 2025
Merged
@DBS06 DBS06 mentioned this pull request Jul 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@sylvioalves sylvioalves sylvioalves approved these changes

@marekmatej marekmatej Awaiting requested review from marekmatej

@avisconti avisconti Awaiting requested review from avisconti

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@Mani-Sadhasivam Mani-Sadhasivam Awaiting requested review from Mani-Sadhasivam

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@simonguinot simonguinot Awaiting requested review from simonguinot

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@yperess yperess Awaiting requested review from yperess

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@kartben kartben

Labels
area: Display area: LED Label to identify LED subsystem area: Samples Samples area: Sensors Sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Adafruit ESP32-S3 and ESP32-S2 Feather Boards
5 participants
@DBS06 @zephyrbot @kartben @sylvioalves @nordicjm