Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers:sensor:sensirion:scd4x: Fixed ID for power down command #85449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petrosyan-van
Copy link

SCD4X_CMD_POWER_DOWN should be 20 instead of 10.

The command to perform power down in SCD41 sensor is 0x36e0, which represents 20th element in scd4x_cmds array. The fix was tested with the actual sensor.

Signed-off-by: Van Petrosyan <van.petrosyan@sensirion.com>
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Sensors Sensors labels Feb 8, 2025
Copy link

github-actions bot commented Feb 8, 2025

Hello @petrosyan-van, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@yperess yperess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on the data sheet, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants