mgmt: fix imply/depends on
#86180
Open
mgmt: fix imply/depends on
#86180
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`imply` should only be used if the code can still operate without the symbol, which is not the case. Move the ID source to a choice symbol, which selects `HWINFO` when required. Signed-off-by: Jordan Yates <jordan@embeint.com>
Mixing `depends on` and `select` is a common cause of Kconfig dependency loops. `select HWINFO` is the more common usage in tree. Signed-off-by: Jordan Yates <jordan@embeint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implyshould only be used if the code can still operate without the symbol, which is not the case. Move the ID source to a choice symbol, which selectsHWINFOwhen required.Mixing
depends onandselectis a common cause of Kconfig dependency loops.select HWINFOis the more common usage in tree.