secure_storage: fix Kconfig dependencies #86181
Open
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanYates
changed the title
`SECURE_STORAGE_ITS_STORE_IMPLEMENTATION_SETTINGS` does not use either the `FLASH_MAP` or `NVS` APIs, only `SETTINGS`. Similarly, `SECURE_STORAGE_ITS_STORE_MODULE` does not consist of any code itself and therefore should not select or imply any options. Signed-off-by: Jordan Yates <jordan@embeint.com>
Mixing `select` and `depends on` is a common source of Kconfig dependency loops and should be avoided. Both `ZMS` and `SETTINGS` are more commonly used with `depends on` rather than `select`. The usage here also contradicts the Zephyr best practices guide for `select`: * Avoid selecting symbols with prompts or dependencies. Prefer depends on. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
force-pushed
the
250222_secure_storage_deps
branch
from
5efcce9 to
89cace2
Compare
|
Removed additional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SECURE_STORAGE_ITS_STORE_IMPLEMENTATION_SETTINGSdoes not use either theFLASH_MAPorNVSAPIs, onlySETTINGS. Similarly,SECURE_STORAGE_ITS_STORE_MODULEdoes not consist of any code itself and therefore should not select or imply any options.Mixing
selectanddepends onis a common source of Kconfig dependency loops and should be avoided. BothZMSandSETTINGSare more commonly used withdepends onrather thanselect.The usage here also contradicts the Zephyr best practices guide for
select: