Skip to content

Conversation

ck-telecom
Copy link
Contributor

add sf32lb52x uart interrupt support

@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch 3 times, most recently from 9eda50d to eb0d82c Compare September 20, 2025 04:09
@ck-telecom ck-telecom marked this pull request as ready for review September 20, 2025 04:19
@zephyrbot zephyrbot added platform: SF32LB area: UART Universal Asynchronous Receiver-Transmitter labels Sep 20, 2025
@ck-telecom ck-telecom marked this pull request as draft September 20, 2025 06:00
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from eb0d82c to a6d3b18 Compare September 20, 2025 06:08
@ck-telecom ck-telecom marked this pull request as ready for review September 20, 2025 06:08
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from a6d3b18 to ab952c0 Compare September 20, 2025 06:14
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from ab952c0 to 04c7444 Compare September 21, 2025 13:15
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the IRQ flags are not being handled properly

if (UART_FLAG_IS_SET(USART_ISR_ORE_Pos)) {
UART_FLAG_CLEAR(USART_ICR_ORECF_Pos);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this silently clears overrun flag, please, check uart.h on how to handle certain error conditions properly (probably others below?)

add sf32lb52x uart interrupt support

Signed-off-by: Qingsong Gou <gouqs@hotmail.com>
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from 04c7444 to c6b3a82 Compare September 21, 2025 15:18
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter platform: SF32LB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants