Add cpp/Chat cmake files #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Feb 5, 2025
| message(FATAL_ERROR "The specified Ice_HOME directory does not exist: ${Ice_HOME}") | ||
| endif() | ||
|
|
||
| find_program(Ice_SLICE2CPP_EXECUTABLE slice2cpp HINTS ${Ice_HOME}/cpp/bin PATH_SUFFIXES x64/Release x64/Debug) |
There was a problem hiding this comment.
Should we add Win32/Release Win32/Debug
There was a problem hiding this comment.
Win32/x64 with cmake is generally figured out from the target os. See https://cmake.org/cmake/help/latest/variable/CMAKE_SIZEOF_VOID_P.html
I know we support Win32 builds with Ice, but I don't really see it being very useful and having to have some extra config to handle this.
There was a problem hiding this comment.
You can still want to use Win32 binaries in x64 platforms, we assume nobody runs a Win32 native platform this days. Same for our x86 linux builds. Anyways this is something we can figure out later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CMakeLists.txt for the chat demos (client and server).
It also reworks the cmake files a use a standard custom package config.