Conversation
- using camelCase for method parameter - acronym above 2 should be pascal case
|
@ajinasokan Below API are not documented on https://kite.trade/docs/connect/v3/ but exposed in library, should we remove it.
Also Alerts API is not present in library. |
|
I'm sorry I can't accept this PR as is. If you are sending a large PR you should ask the maintainers first if this is something they are ready to accept. Create an issue, describe your plan, see if that aligns with the project's roadmap, then work on it and send a PR. Feel free to use this patch for your own use case. But here are the reasons I can't accept this:
Having said that, I will keep the PR open because it has some parts that can be incorporated to the library. Will let you know once that is merged. From now on please make sure to create an issue first describing your plan before sending a large PR. |
@ajinasokan This PR introduces support for async/await and removes the use of dynamic. It also includes several additional improvements: