fix: type defination for market_protection in placeOrder and modifyOrder#119
Open
shubham-singh wants to merge 2 commits intozerodha:masterfrom
Open
fix: type defination for market_protection in placeOrder and modifyOrder#119shubham-singh wants to merge 2 commits intozerodha:masterfrom
shubham-singh wants to merge 2 commits intozerodha:masterfrom
Conversation
Author
|
Hi @ranjanrak, can you take a look at this PR and merge if it looks good to you. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request releases version 5.2.1 of the
kiteconnectpackage, focusing on a bug fix to the TypeScript type definitions. The main change is the addition of a missing parameter to method signatures, ensuring better type safety for users.Bug Fixes:
market_protectionparameter to theplaceOrderandmodifyOrdermethod signatures in the type definitions to keep them in sync with the implementation.Release Management:
5.2.1inpackage.jsonto reflect the new bugfix release.